Added custom error messages for dependency and plugin issues

[Nimisha94]

This PR provides support to pass custom error messages for the following errors -

• dependency version doesn't match dependencyManagement version
• dependency has version tag, and version tags are disallowed
• dependency has exclusions, and exclusions are disallowed
• dependency is not in dependencyManagement
• plugin version doesn't match pluginManagement version
• plugin is not in pluginManagement

[stevie400]

Can you please share some example output here?

[Nimisha94]

[Nimisha94]

Now the output looks something like this -

[stevie400]

LGTM, with one small comment. I wonder if @jhaber has more thoughts on formatting the output.

It could be worth taking a look at how the custom banned dependencies message is displayed and checking that this is consistent. I also wonder about putting more newlines in between the log messages.

[jhaber]

Awesome! How does it look if the custom message is multiline?

[Nimisha94]

Multiline message -

[jhaber]

And if a user doesn't set any custom messages?

[Nimisha94]

If a user doesn't give in the pom file, a blank line is shown as of now.

[jhaber]

I think we should probably check if the custom message is null before calling log.warn

[Nimisha94]

I tweaked the code to display the custom message only if given. So, the blank line above doesn't show up even if the user doesn't set any custom messages. For example, looks like this if the user doesn't set <unmanagedDependencyMessage> in the pom file

[stevie400]

I think we should also omit the log.warn(""); if there are no messages to print. One approach could be to add the messages we want to print to a list instead of log.warning them immediately. Then we could log the empty line only when we have messages to print.

[Nimisha94]

Yes. I was thinking of logging it only when the success flag is false (which happens when there is some dependency or plugin issue).

[Nimisha94]

I changed the code to display the custom messages only if present by adding them to a list before logging them as warnings. The output is looks like this (if custom messages are given)-

The output looks like this if the custom messages are not given -

[stevie400]

Nice, I think this looks great! Have you experimented with adding more newlines / indentation? What do you think about

[WARNING] Found version mismatches in managed dependencies:
[WARNING]   Custom version mismatch message

[Nimisha94]

Yes. It's behaving in the similar way as the bannedDependencies custom messages has been implemented by the Apache plugin.

Multi-line message without any spaces at the beginning of the second line would be shown this way [WARNING] Found version mismatches in managed dependencies : Custom message line 1. Custom message line 2

[Nimisha94]

Output look like this now

Given any custom message -

No custom messages given -

[stevie400]

LGTM w/ tweak