HubSpot / dropwizard-guicier

Apache License 2.0
42 stars 22 forks source link

Upgrade Dropwizard to 2.x #61

Open OneCricketeer opened 4 years ago

OneCricketeer commented 4 years ago

Dropwizard 1.3.x has had many upgrades.

Dropwizard 2.0 is also out now.

jhaber commented 4 years ago

Thanks for bringing this up. Currently dropwizard-guicier uses jersey2-guice in order to make HK2 and Guice work together. However, this project is abandoned and the repo is archived. Luckily, Jersey no longer requires HK2 and the dependency injection implementation is pluggable. I've started working on a Guice-based implementation in this repo: https://github.com/HubSpot/jersey2-guicier

Once that's in a usable state, it should be a lot easier to upgrade to newer versions of Dropwizard/Jersey and it should hopefully fix a lot of the issues caused by using both HK2 and Guice

OneCricketeer commented 4 years ago

👋

Once that's in a usable state

Update?

jhaber commented 4 years ago

I've been working on jersey2-guicier intermittently, however the API that you need to implement is pretty tied to HK2. I have most of the tests passing, but there are still a bunch of Guice errors when trying to actually use it.

Alexander-Paeshin commented 4 years ago

Is there some date when library with Dropwizard 2.0 support will be released?

OneCricketeer commented 4 years ago

@Alexander-Paeshin I think the answer lays somewhere in the second comment.

Specificallly, this project is abandoned and the repo is archived

OneCricketeer commented 4 years ago

Which, btw, @jhaber - this repo is not archived.

tmack8001 commented 4 years ago

@OneCricketeer @jhaber was referring to this repo -> https://github.com/Squarespace/jersey2-guice (in context to his earlier statement about that project.

tmack8001 commented 4 years ago

I did find that https://github.com/xvik/dropwizard-guicey (another guice+dropwizard library) does support 2.x now. If upgrading is important for folks maybe migrating to this library which has had more regular contributions is in order... last commit here was back in August.

image