search

HubSpot / eslint-config

HubSpot's ESLint configurations
1 stars 2 forks source link

Add ignoreRestSiblings flag on no-unused-vars rule #4

Closed spiicy-sauce closed 7 years ago

spiicy-sauce commented 7 years ago

This allows for a common pattern of omitting object keys via destructuring. This rule option became available in 3.17.0, and other workarounds to get the linter to ignore this pattern are quite annoying.

Phoenixmatrix commented 7 years ago

Looking at conversations related to this here, I'm not sure we should keep this.

Even if we do, the versions went from fixed to carret, which is almost definitely not what we want.

@JHilker @also

TrevorBurnham commented 7 years ago

Even if we do, the versions went from fixed to carret, which is almost definitely not what we want.

I noticed that, but Airbnb does it too, so I'm not worried.

"But Trevor, if Airbnb jumped off a cliff, would you do it too?"

Yes.

Phoenixmatrix commented 7 years ago

AirBNB's setup also breaks constantly. Which was why we did not put the carrets :)

TrevorBurnham commented 7 years ago

Alright; how do you want to proceed? Revert and unpublish 7.4.0?

Phoenixmatrix commented 7 years ago

Probably can just push a new version instead of unpublishing.

spiicy-sauce commented 7 years ago

@Phoenixmatrix Yeah I'm on board with reverting (based on that other conversation). But tbh the versioning issues were a lot bigger for me. I literally can't npm install at this point because this package requires a specific minor versions of several packages.

spiicy-sauce commented 7 years ago

@TrevorBurnham @Phoenixmatrix 7.4.0 wasn't actually published on npm yet since I didn't have the right credentials.

TrevorBurnham commented 7 years ago

Ah, I'll revert, then.

TrevorBurnham commented 7 years ago

^ Reverted.