search

HubSpot / facewall

Grid visualization of Gravatars for an organization
http://github.hubspot.com/facewall/
MIT License
138 stars 38 forks source link

Strange calculations in getGrid #10

Open theold190 opened 9 years ago

theold190 commented 9 years ago

Experiencing the same issue as described in "Gravatar images full screen of the browser window #7". Found out that getGrid function is working a bit strange. Here are my notes:

  1. The recursive calls to getGrid are passing options structure instead of columnWidth.
  2. getGrid is always using $(window).width() to initialize options.width, so there is no much point in the recursive calls.