search

HubSpot / facewall

Grid visualization of Gravatars for an organization
http://github.hubspot.com/facewall/
MIT License
138 stars 38 forks source link

Not all pictures are displayed #13

Open theold190 opened 9 years ago

theold190 commented 9 years ago

While testing the application with default collection of employees, I have noticed that depending on the size of the window different number of pictures displayed. Most of the time you will see less than 12 pictures. To see all of them you need to make height of the windows quite small.

It feels like some pictures are not added in employee_loaded function. There we add employees only if we have enough for the whole row if row_bucket.length is grid.length. This might leave some pictures not displayed.

theold190 commented 9 years ago

Something similar to https://github.com/agamatrix/facewall/commit/d23ba6a5c637b35fc71275f673d5c2ee94db2d87 should fix the issue.