HubSpot / facewall

Grid visualization of Gravatars for an organization
http://github.hubspot.com/facewall/
MIT License
138 stars 38 forks source link

Facewall refreshes view from time to time #14

Closed theold190 closed 9 years ago

theold190 commented 9 years ago

From time to time you see that the whole view refreshes. After some time pictures were displayed the view get cleared and view loads from the beginning. This is not the nicest behavior for a screen that might hang in the hall.

Testing on a Firefox browser.

adamschwartz commented 9 years ago

Yup, this is a setting which you can set as large as you want.

I agree it’s not ideal, but I found that without something like this, the app would crash its tab process in Chrome after a while. (My guess is there was some sort of memory leak but I wasn’t able to trace it at the time.)

The refresh also served another purpose, which was to ensure that the latest employee images were being used. At HubSpot, we chose to use Gravatar images of employee emails for the data, which means that any employee could update her image herself at any time by changing it on Gravatar’s site.

If the memory leak could be identified, I’d love to remove the refresh and implement the employee image cache busting in a smarter way (one which doesn’t clear all of the images in the view), but it’s very tricky to catch especially because it’s intermittent and only seems to happen on Windows 7 in Chrome (which is what HubSpot’s wall is powered by) after the process has been running for an hour or more.

But since it is a setting, you can set that number to something large and you’ll never have to think about it. :smile: