HubSpot / facewall

Grid visualization of Gravatars for an organization
http://github.hubspot.com/facewall/
MIT License
138 stars 37 forks source link

Gravatar images full screen of the browser window #7

Closed Friss closed 10 years ago

Friss commented 10 years ago

Not sure if it's my specific settings or a bug.

gravatarimages

For about 5 seconds it did line up the images correctly but it refreshed and became full screen again.

Running it here: http://facewall.justdev.in/facewall/ Using dokku and just hosting with brunch currently.

adamschwartz commented 10 years ago

Since very few images are loading, the tiling algorithm can't figure out a way to fill the space any other way. When I make the browser window wide and short, it tiles better.

screen shot 2013-12-09 at 12 56 18 pm

theold190 commented 9 years ago

It feels like this bug is related to columnWidth calculation. In the beginning columnWidth has a default value (150px) and grid looks ok. But after some time columnWidth is updated in employee_loaded function.

In my case columnWidth gets ~484px for a screen width of 1680px. With that width value we can't place the minimum of 5 columns, so currentBestNumColumns become equal to 1.