chore: Switch developerTestAccount & sandbox usages from `lib` to `api`

HubSpot / hubspot-cli

A CLI for HubSpot

https://developers.hubspot.com

Other

153 stars 57 forks source link

chore: Switch developerTestAccount & sandbox usages from `lib` to `api` #1126

Closed joe-yeager closed 1 month ago

joe-yeager commented 1 month ago

Description and Context

Switches to use api/developerTestAccounts.ts instead of lib/developerTestAccounts.ts because we are deprecating lib/developerTestAccounts.ts because it is a very thin wrapper and we can directly use api/developerTestAccounts.ts
Switches usages of lib/sandboxes.ts to api/sandboxHubs and api/sandboxSync

Companion PR: https://github.com/HubSpot/hubspot-local-dev-lib/pull/178

Who to Notify

@kemmerle @adamawang @camden11 @brandenrodgers

adamawang commented 1 month ago

Should I look into doing something similar with the sandboxes file? Since that doesn't really add much either

joe-yeager commented 1 month ago

Should I look into doing something similar with the sandboxes file? Since that doesn't really add much either

@adamawang Oh, good to know. I'll just add it to these PRS since I'm already in here and we are trying to build up some breaking changes for a v2 of LDL

joe-yeager commented 1 month ago

LGTM. From what I can tell, this doesn't depend on any upcoming changes in LDL either so you could safely merge into main rather than next if you wanted to

I believe it's depending on the changes you made to the API calls returning the full promise

camden11 commented 1 month ago

🤦 It absolutely is, i'm losing track of what's on next and what's not haha