HubSpot / hubspot-cli

A CLI for HubSpot
https://developers.hubspot.com
Other
154 stars 60 forks source link

Clean up generic errors #1147

Closed camden11 closed 2 months ago

camden11 commented 2 months ago

Description and Context

This removes the "an error has occurred" text the prefaces many error messages, since it's redundant with the [ERROR] logged at the beginning of every error message. The intent of this log was to inform users that a specific kind of error had occurred, but I think it's likely that that's not really relevant information for most people. Also, with the new error setup, most specific kinds of errors are already handled as system errors or hubspot HTTP errors.

See issue: https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/594

Screenshots

Having a hard time finding a good example of this, since the vast majority of errors are HubSpot HTTP errors or system errors and are handled different. Here's an example from hs project add that I've since fixed.

Before

Screenshot 2024-08-22 at 4 08 04 PM

After

Screenshot 2024-08-22 at 4 08 22 PM

Who to Notify

@brandenrodgers @joe-yeager