search

HubSpot / messenger

Growl-style alerts and messages for your app. #hubspot-open-source
http://github.hubspot.com/messenger/
MIT License
4.02k stars 406 forks source link

Adding a spinner to the Future theme #1

Closed adamschwartz closed 11 years ago

adamschwartz commented 11 years ago

@zackbloom starting this PR off. After you add the on/off classes (message-spinner-active, retrying-soon, retrying-later, or whatever you decide), let me know because there are a couple bugs I'll need to clean up at that time. (Believe it or not, the alert orb is changing its size when the spinner is toggled, so I'll need to adjust accordingly in the activated class. There are also a few minor tweaks still left to be made but it will make more sense to make those after the coffee is fleshed out.)

zackbloom commented 11 years ago

All the classes and such have been added. I modified it so it only shows on error retries for the moment (I wasn't sure if you intended it to be the 'how long till the message disappears' countdown, lemme know). I also added a 500 example which will trigger the retries to the index page in gh-pages.

I still think it's a good idea to come up with a js theming system, but I haven't been able to figure out how exactly I'd like to do it, so this might make it to master and get broken out again when the time is right.