HubSpot / messenger

Growl-style alerts and messages for your app. #hubspot-open-source
http://github.hubspot.com/messenger/
MIT License
4.03k stars 408 forks source link

Uncaught TypeError: Cannot read property 'length' of undefined in Chrome 48 #104

Open kjantzer opened 8 years ago

kjantzer commented 8 years ago

As of Chrome 48 (specifically tested on 48.0.2564.97), the following error appears upon initialization

Messenger()

yields...

Uncaught TypeError: Cannot read property 'length' of undefined (line 840)
kjantzer commented 8 years ago

It appears this.history is not being set...

kjantzer commented 7 years ago

Is no one else having this issue? Now on Chrome 51 and issue still exists. Even with 1.5

crissty commented 7 years ago

I also have this error, but not how to fix it

kjantzer commented 7 years ago

@crissty I ended up removing the plugin and using my own code since this project doesn't seem to be thriving

Friss commented 7 years ago

Do either of you have an example page where this is happening? I can't seem to replicate it.

leompeters commented 7 years ago

I am having a similar issue but for this.options.themes in the file https://github.com/HubSpot/messenger/blob/master/docs/welcome/javascripts/theme-sel.js#L25:

Uncaught TypeError: Cannot read property 'themes' of undefined

leompeters commented 7 years ago

Got it!!! My similar issue was gone with UnderscoreJS VERSION 1.4.3 and BackboneJS VERSION 0.9.10.