search

HubSpot / messenger

Growl-style alerts and messages for your app. #hubspot-open-source
http://github.hubspot.com/messenger/
MIT License
4.02k stars 405 forks source link

Testing & Linting #31

Open BennyC opened 11 years ago

BennyC commented 11 years ago

Thinking about integrating headless testing into the Grunt process, also some Linting. Obviously didn't want to go straight ahead with this, as I wanted to see if you have any linting rules already in place at HubSpot that you'd want to follow?!

Any other things you'd like?! Was thinking once we get automated linting/testing in place, could possibly look into using Travis for builds to ensure quality of a build/tag?

zackbloom commented 11 years ago

The headless testing would be awesome, it'll be interesting to see how well Phantom works with the existing Jasmine tests. Linting I'm personally a little mixed on (it can be pedantic), but not everyone feels that way. Travis would also be awesome, it's github integration seems very cool.

BennyC commented 11 years ago

Cool, I'll scrap the whole linting idea for now then. Just playing with the testing side of things, which is working fine. I'm also going to add in a watch, which will run on file changes, rebuild, and retest.

I'll look into the Travis integration tonight/sometime this week!

ilanbiala commented 10 years ago

@BennyC any progress on this?