search

HubSpot / messenger

Growl-style alerts and messages for your app. #hubspot-open-source
http://github.hubspot.com/messenger/
MIT License
4.02k stars 406 forks source link

Fixes for bower.json #40

Closed pdf closed 11 years ago

pdf commented 11 years ago

Refs #39

I'm pretty new to all this JS packaging stuff, but it seems like currently people tend to maintain two repositories for dealing with bower, with a bower-specific repository that contains only the built version and a bower.json. That seems like a whole lot of wasted effort, so I don't know if you want to go that far, hopefully that gets resolved after the bower rewrite is finished. For now I've just fixed made the above changes so that it works - though files are still deployed to messenger/build/(js|css) - and doesn't ship all the extra stuff like libs and source. All in all, bower still seems a little confused about what main is actually meant to be currently, so, I've just made sure it references everything required.

I don't know if this is expected to work with JQuery 2.0.0, but if not, it might also be worth adding a dependency restriction to ~1.9.1

zackbloom commented 11 years ago

Works for me, thanks @pdf.

zackbloom commented 11 years ago

We will have to conduct an inventory of exactly which versions of jQuery are supported. I added an issue to fix whatever causes problems on 2.0.0.

pdf commented 11 years ago

Is it possible to retag or bump the version? It's sadly required until the bower rewrite introduces git ref support.

zackbloom commented 11 years ago

I just pushed v 1.3.1, let me know if that is not what you need.

pdf commented 11 years ago

The 1.3.1 tag somehow seems to have picked up the old bower.json?

https://github.com/HubSpot/messenger/blob/3c392d37e12ec113dcf7c25b1886fea95f0a7d4d/bower.json

zackbloom commented 11 years ago

Ah, yea. Would a 1.3.1a release help?

pdf commented 11 years ago

Sadly, that's not semver, so I think bower will barf :-(

zackbloom commented 11 years ago

Ah yea, and 1.3.1-a would compare lower than 1.3.1. I'll try and get 1.3.2 out in the next day or so.

pdf commented 11 years ago

No worries, thanks Zack