Messenger().error() ignores default options

HubSpot / messenger

Growl-style alerts and messages for your app. #hubspot-open-source

http://github.hubspot.com/messenger/

MIT License

4.03k stars 408 forks source link

Messenger().error() ignores default options #87

Open Upperstage opened 9 years ago

Upperstage commented 9 years ago

I set Messenger defaults as follows:

Messenger.options = { hideAfter: 5, extraClasses: 'messenger-fixed messenger-on-top messenger-on-right', showCloseButton: true, theme: 'flat' };

However, these options are ignored when I call the error method: Messenger().error({ message: 'SAVE' });

I "fixed" this problem by adding the following to the error method (line 1155): m_opts = $.extend(m_opts, this.options);

geekjuice commented 9 years ago

Err, yea this does seem like and issue with Messenger at the moment. Thanks for pointing this out because it actually seems like passing options outside of the action methods (e.g. error, post, etc.) directly do not affect Messenger. If you would like to contribute to the project and take a swing at the issue, that'd be awesome. Otherwise, I'll keep a note of this and make sure it gets resolved in a future iteration soon.