HubSpot / messenger

Growl-style alerts and messages for your app. #hubspot-open-source
http://github.hubspot.com/messenger/
MIT License
4.02k stars 406 forks source link

Remove Backbone Dependency #9

Closed zackbloom closed 11 years ago

zackbloom commented 11 years ago

The biggest use of Backbone right now is to do the mechanics of event binding, we should be able to extract that bit from the Backbone source.

codeablehq commented 11 years ago

No need to ping, I'll be watching this :smile:

snikch commented 11 years ago

+1 on this this. I love the concept, but have no intention of using backbone.

codeablehq commented 11 years ago

And as I mentioned on HN, if you require jQuery as a dependency, why not make it a proper jQuery plugin.

hugodias commented 11 years ago

ill wait for this to lose the backbone dep ... +1

kyleboddy commented 11 years ago

Agreed. Will use if backbone is removed.

zackbloom commented 11 years ago

@carmivore It is available at $.fn.messenger, if you have a reason to use it.

sorensen commented 11 years ago

+1 for backbone removal.

ghost commented 11 years ago

+1 for removing backbone dep.

joshua1 commented 11 years ago

+1 for backbone removal.please remove backbone dependency.Thanks

danvarga commented 11 years ago

+1

vafada commented 11 years ago

+1

nixpulvis commented 11 years ago

+1

rudf0rd commented 11 years ago

+1!

bosgood commented 11 years ago

Thanks for the support, everyone. You can track the progress of this here.

joelmoss commented 11 years ago

+1

Need a hand @bosgood ?

bosgood commented 11 years ago

@joelmoss Sure, any help is welcome- I've just been hacking on it when I've got free cycles :)

joelmoss commented 11 years ago

Check out issue #23

zackbloom commented 11 years ago

Update on this: You can take a look at the no-backbone branch for the current state of this project. If you open SpecRunner.html you can see that there are about 12 tests which are not currently passing, anyone who wants to take a crack at them is welcome!

zackbloom commented 11 years ago

This should do it: https://github.com/HubSpot/messenger/pull/29

codeablehq commented 11 years ago

Thank you! :+1: