search

HubSpot / odometer

Smoothly transitions numbers with ease. #hubspot-open-source
http://github.hubspot.com/odometer/docs/welcome
MIT License
7.3k stars 713 forks source link

Fixed: AMD exporting issues #102

Open dkulichkin opened 9 years ago

dkulichkin commented 9 years ago
  1. When built as an npm module by webpack - gets exported by default as an AMD module, which gives error: "Uncaught Error: define cannot be used indirect" - changed commonJS schema to be first in the exporting format order
  2. Exporting as amd module does not check jquery's presence
rickihastings commented 8 years ago

:+1:

barinovos commented 8 years ago

Guys, please, can you merge it to the master?? I really need to export it for using with webpack and Angular2

zackbloom commented 8 years ago

I believe odometer.js is a built file, so this change would need to be made in odometer.coffee.

pablodenadai commented 8 years ago

@dkulichkin any chance you could make this change to .coffee instead? Cheers.