HubSpot / odometer

Smoothly transitions numbers with ease. #hubspot-open-source
http://github.hubspot.com/odometer/docs/welcome
MIT License
7.3k stars 712 forks source link

Remove jquery from dependencies in AMD #128

Closed jeerbl closed 7 years ago

jeerbl commented 7 years ago

Refering to #127.


This change is Reviewable

outdooricon commented 7 years ago

@zackbloom @marcneuwirth @adamschwartz can we please get this in and released. This blocks odometer from being able to be used in more modern tools like webpack, when we aren't using jquery (which is quickly becoming common). I really need this so I can use this in our react app. Thank you very much!

jeerbl commented 7 years ago

Hello guys!

Any news on this? Can we merge this?

Thanks, Jérôme

alanrubin commented 7 years ago

Please release that change ! I'm not using jQuery in my app and that is a blocker... Thanks for this great library !

JetFault commented 7 years ago

A temporary workaround for this is doing the same thing you would do for backbone without jQuery.

My webpack 2 config looks something like this:

module: {
    loaders: [
      {
        test: /(backbone|odometer)\.js$/,
        loader: 'imports-loader?define=>false'
      }
    ]
  },
  plugins: [
    new webpack.IgnorePlugin(/^jquery$/)
  ]

Make sure to npm install the imports-loader

jeerbl commented 7 years ago

Sorry to ask again but, where are we on this? Is there anything holding up?

@zackbloom @flex69

Thanks, Jérôme

zackbloom commented 7 years ago

Sorry for the delay @jeerbl

alanrubin commented 7 years ago

Do you need to bump a new version to npm so we can get access to it? I'm having issues getting yarn to see the update.

zackbloom commented 7 years ago

Published as v0.4.8