search

HubSpot / offline

Automatically display online/offline indication to your users
http://github.hubspot.com/offline/docs/welcome
MIT License
8.67k stars 848 forks source link

Service Worker support #239

Open staminna opened 7 years ago

staminna commented 7 years ago

Hi

I am using Google's Read Through Service worker example, although it works fine without Service Worker's code, offline.js doesn't detect when the connection is lost and SW code kicks in. Please find the code files attached in this google's github repository link

dupenna commented 6 years ago

Hi.

I'm experiencing the same issue with service worker.

It works fine when I load it in online mode, but if I go offline and reload the URL, the first status in "on".

@staminna, did you found a work around?

staminna commented 6 years ago

Hi

No. I’m not into using a project when they take months to reply or don’t help at all. I have probably used some other solution.

Sorry

On 23 Jun 2018, at 16:10, dupenna notifications@github.com wrote:

Hi.

I'm experiencing the same issue with service worker.

It works fine when I load it in online mode, but if I go offline and reload the URL, the first status in "on".

@staminna https://github.com/staminna, did you found a work around?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HubSpot/offline/issues/239#issuecomment-399680957, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfcbOUCOnkiilUnihE9I0qThxOpf_FHks5t_kxCgaJpZM4LoRAB.

ArmorDarks commented 5 years ago

Obviously, you should filter in Service Worker fetch to the URL, which you're hitting with Offline, otherwise, SW will return cached reply and Offline will think that everything is ok.