search

HubSpot / offline

Automatically display online/offline indication to your users
http://github.hubspot.com/offline/docs/welcome
MIT License
8.66k stars 847 forks source link

errors in IE8 #91

Open yporodko opened 10 years ago

yporodko commented 10 years ago

I opened http://craigshoemaker.github.io/offlinejs-simulate-ui/ in IE10 with emulation of IE8 and I've got errors:

SCRIPT5: Access is denied.
File: offline.min.js, Line: 2, Column: 6307

SCRIPT5007: Unable to get property 'appendChild' of undefined or null reference
File: offline-simulate-ui.min.js, Line: 2, Column: 346

Also in real IE8 I have errors:

SCRIPT438: Object doesn't support property or method 'addEventListener'
File: offline.min.js, Line: 2, Column: 1709

in README for offline.js you clame to support IE8+

Browser Support

Modern Chrome, Firefox, Safari and IE8+

version of offline.min.js that I'm using is v0.7.8

indolering commented 9 years ago

IE8 has 1.5% of global users and has 6 more months of security updates. I move to close this ticket and update the README to specify IE9.

geoffcallender commented 8 years ago

Possibly addressed by https://github.com/HubSpot/offline/issues/209 .