search

HubSpot / prettier-maven-plugin

Apache License 2.0
116 stars 23 forks source link

Add eol conversion #11

Closed MSaguer closed 4 years ago

MSaguer commented 4 years ago

I had a new option endOfLine to enable the EOL conversion. Usefull when users uses many different OS on the same project

jhaber commented 4 years ago

Thanks for the PR! The endOfLine changes look good to me. Looking at the binPath related changes, I think it would break for people on Linux/OSX because /bin/diff doesn't exist normally (at least as far as I can tell). What do you think about just changing /bin/sh to sh and requiring that both sh and diff are on the path (which they should be already for Linux/OSX users).

MSaguer commented 4 years ago

I don't know how I totally mixed my commits. binPath was a test I performed on the windows compliance. It should be removed from here. I remove it immediately

MSaguer commented 4 years ago

Your comment about diff and sh path is already taken into account in the other pull request #12

jhaber commented 4 years ago

thanks for the contribution 👍