Closed GoldSubmarine closed 3 years ago
Is there any response?
If anything needs to be modified please let me know.I'm not sure if you agree with the design 😃
Sorry for the delay, I can review this PR shortly. My main question is how the glob parameter should interact with our regular source directory discovery (should it replace the discovered directories? union the results? filter the directories to files that match this glob?)
In my opinion, if the user customizes, all of prettier functions should be provided, not only format java files, but also format markdown or javascript. What files need to be formatted is totally up to him, so we don't have to do anything for the result.
I just test by the absolute path, relative paths are now invalid.
Maybe we can modify the startup path of nodejs to the current project root
I've already tested it, relative paths also take effect.
Perhaps by default, we should format all Java files, so we should remove the following code. Relate to #34
If users only need to format certain folders, they should customize by glob config. Relate to #22
I need this too. Would be great if the PR is merged. :)
Yes it would be awsome if this plugin could format all of my project. Please merge.
Sorry again for the delay, I went a slightly different direction in #39 with support for multiple patterns, rather than needing to stuff everything into a single glob
I've already tested it,it works well