search

HubSpot / prettier-maven-plugin

Apache License 2.0
116 stars 23 forks source link

Allow globs without files to still fail check. #50

Open magisyn opened 3 years ago

magisyn commented 3 years ago

If prettier sees that a glob doesn't find any files it currently will not fail as the status is 2 but one of the globs didn't find any files.

These changes allow for a final method to be run when the prettier process completes to fail if files were found to not pass the code style check even if a glob didn't find any files. This can happen if you have a sub module that doesn't have any *.html files but other modules do.

As part of this, the glob suffixes are used to retrieve the list of files that failed the check to be output. Fixing https://github.com/HubSpot/prettier-maven-plugin/issues/49

magisyn commented 2 years ago

@jhaber Any chance you'll have some time to look at these changes this week?

magisyn commented 2 years ago

@jhaber Any chance you'll have time to look at these changes?

magisyn commented 2 years ago

@jhaber Happy to incorporate any feedback on this PR. I'd love to get this in soon so we can start checking on all files.

jhaber commented 2 years ago

Sorry for the lengthy delay, I just opened #57 which I think should fix #49. Next I'll take a look at this PR and try to understand the issue and the fix

jhaber commented 1 year ago

Is this still an issue, now that #57 is integrated?