HubSpot / prettier-maven-plugin

Apache License 2.0
116 stars 23 forks source link

Download node and prettier, rather than bundling #64

Closed jhaber closed 2 years ago

jhaber commented 2 years ago

This is a big rewrite to the plugin. Rather than bundling node, the plugin will download it from https://nodejs.org/dist/ as needed. And then rather than bundling prettier-java, it will use the npm binary inside of the node download to npm install prettier-plugin-java@{requestedVersion} This means we won't have make code changes and releases to this plugin in order to keep up with node or prettier-java releases. I also added support for downloading Mac arm64 binaries of node, which runs much faster on M1 macbooks than the x64 binaries.

The main breaking change is that the beta versions of prettier-java, such as 0.8.2-hubspot are gone, so users will need to migrate to a proper prettier-java release before upgrading to this version

@stevegutz @snommit-mit @Xcelled @kmclarnon

jhaber commented 2 years ago

Should fix #61 and #63