search

HubSpot / prettier-maven-plugin

Apache License 2.0
116 stars 23 forks source link

Running on ARM #66

Closed warrenseine closed 2 years ago

warrenseine commented 2 years ago

I'm running under Docker on macOS on an M1 chip. By default, Docker Desktop runs Linux on linux/arm64/v8, which is pretty cool.

However, the Node executable bundled with prettier-maven-plugin is built for x86_64 and fails with:

root@host:/var/code# /root/.m2/repository/com/hubspot/maven/plugins/prettier-maven-plugin/0.17/prettier-maven-plugin-0.17-node-12.13.0-linux.exe
qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory

When I explicit ask Docker to run with platform linux/amd64, it works, so there's a workaround. However, I'd be much better to have a compatible Node for this architecture.

I wonder if #64 would help here?

warrenseine commented 2 years ago

I see that indeed, this seems to be the case. Good luck with the merge!

jhaber commented 2 years ago

👍 should have that rolled out next week

jhaber commented 2 years ago

I just released this as part of version 0.18 by the way, in case you were waiting for a release

warrenseine commented 6 months ago

Coming back to this issue as it solved Darwin ARM64, but not Linux ARM64. This should be easily fixed with #104 now.