search

HubSpot / prettier-maven-plugin

Apache License 2.0
116 stars 23 forks source link

Remove Guava dependency #98

Closed jtkiesel closed 11 months ago

jtkiesel commented 11 months ago

Replace the few Guava uses with standard Java equivalents, and remove Guava as a dependency (to reduce the plugin's footprint).

jhaber commented 11 months ago

Thanks for the PR, I left a few comments. Just curious if the Guava dependency was causing any particular issues? (if so, we have other plugins we may want to remove it from)

jtkiesel commented 11 months ago

Thanks for taking the time to review, and most importantly for catching my careless mistakes!

To clarify, there was nothing in the Guava dependency causing any issues, I simply thought that I could reduce the plugin's dependency footprint by replacing Guava with newer Java functionality.

Because of that, feel free to close this PR if you're uninterested -- its only real improvement is the reduction of the dependency footprint (the NIO changes could offer a slight performance improvement).

jhaber commented 11 months ago

Looks good to me, thanks!