search

HubSpot / slack-client

An asynchronous HTTP client for Slack's web API
Apache License 2.0
115 stars 53 forks source link

Add Header Block implementation #193

Closed richardxu100 closed 4 years ago

richardxu100 commented 4 years ago

Closes #190

I modeled this off of SectionIF.java and the Header API described here. I'm very new to java, so any comments or suggestions would be very appreciated.

richardxu100 commented 4 years ago

Thanks for the suggestion @szabowexler! Please let me know if there's anything else that would be helpful to add to this PR

szabowexler commented 4 years ago

Sure! The final check here is for you to confirm that you've posted a sample message, and it worked. Once you do that, just take a quick screenshot of the result and drop it here for posterity, and we'll go ahead and merge. You won't be able to use it immediately until we cut a release, but we can try and do that sometime towards the end of this week.

richardxu100 commented 4 years ago

Sure! The final check here is for you to confirm that you've posted a sample message, and it worked. Once you do that, just take a quick screenshot of the result and drop it here for posterity, and we'll go ahead and merge. You won't be able to use it immediately until we cut a release, but we can try and do that sometime towards the end of this week.

Screen Shot 2020-09-15 at 10 16 10 AM

I was able to test that the header block is working properly! I'm not sure however if my method of testing is sufficient, as I basically just copied this file into my project that is using the slack-client. I think a more proper way to test this library would be to somehow import my local, modified slack-client into my project, instead of using the global version of this library, though I'm not sure how this would be done as I'm very new to java development. Do you have any suggestions on how to test this PR more properly, or is the testing I did sufficient?