search

HubSpot / slack-client

An asynchronous HTTP client for Slack's web API
Apache License 2.0
115 stars 53 forks source link

View state bug fix + misc #195

Closed lightbody closed 4 years ago

lightbody commented 4 years ago

Resolves issue #194, also includes support for dynamic external selectors and shortcut payloads

szabowexler commented 4 years ago

I keep forgetting we made that choice. OK I'll approve and we can roll forward.

On Tue, Oct 6, 2020 at 2:48 PM Patrick Lightbody notifications@github.com wrote:

@lightbody commented on this pull request.

In slack-base/src/main/java/com/hubspot/slack/client/models/interaction/ShortcutIF.java https://github.com/HubSpot/slack-client/pull/195#discussion_r500522101:

@@ -0,0 +1,18 @@ +package com.hubspot.slack.client.models.interaction; + +import com.fasterxml.jackson.databind.PropertyNamingStrategy.SnakeCaseStrategy; +import com.fasterxml.jackson.databind.annotation.JsonNaming; +import com.hubspot.immutables.style.HubSpotStyle; +import com.hubspot.slack.client.models.SlackChannel; +import org.immutables.value.Value.Immutable; + +@Immutable +@HubSpotStyle +@JsonNaming(SnakeCaseStrategy.class) +public interface ShortcutIF extends SlackInteractiveCallback {

  • String getTriggerId();
  • default SlackChannel getChannel() {

The reason I didn't make that change was because it would require changing SlackInteractiveCallback which seemed like a big breaking change to the API affecting a lot of users.

If you're good with that, I think I should probably resubmit as a separate PR dedicated for just this change because it's going to impact a lot of files.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HubSpot/slack-client/pull/195#discussion_r500522101, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABT6K4UYROSSA3LCUKGUMPLSJNRBRANCNFSM4SGJCUEA .

-- Elias Szabo-Wexler Carnegie Mellon University Computer Science, German, Engineering Studies 2015

lightbody commented 4 years ago

FWIW, I have a couple small changes I can also send along in a second PR, if you're so inclined to include them in this release ;)

lightbody commented 4 years ago

Update: if you're so inclined, #196 and #197 are my two other changes in my fork. If those get included I'm caught back up to the next release. But no biggie if you don't want to include them. Thanks!