search

HubSpot / slack-client

An asynchronous HTTP client for Slack's web API
Apache License 2.0
115 stars 53 forks source link

Normalize some of blocks' presentational data #266

Closed omotnyk closed 2 years ago

omotnyk commented 2 years ago

Same as https://github.com/HubSpot/slack-client/pull/258 but for some of the BlockKit models.

leonidhladii commented 2 years ago

@omotnyk looks good at all. Do we plan to add the same validation stuff to External...Menu, Date/Time pickers, OverflowMenu?

omotnyk commented 2 years ago

@leonidhladii Yeah, but I didn't want to spend time normalizing all the input data that we don't use at this point.

Still, I realized that we at least use ExternalSelectMenu so I'll add its normalization as well. Thanks!

omotnyk commented 2 years ago

@leonidhladii Getting back to this, I don't think there is much we can normalize in ExternalSelectMenu. There is a placeholder but don't really use it in a way that can cause issues with its length.

Do you think we can merge this PR?

leonidhladii commented 2 years ago

Works for me, good job 🚀