search

HubSpot / slack-client

An asynchronous HTTP client for Slack's web API
Apache License 2.0
114 stars 53 forks source link

DO NOT MERGE/REVIEW. Add shared channels filtering. #295

Closed nliutyi-hs closed 1 year ago

nliutyi-hs commented 2 years ago

In this PR we add filtering logic to filter out shared channels, in case when ConversationsListParams.shouldExcludeSharedChannels() is true.

nliutyi-hs commented 2 years ago

@omotnyk So your main concern is to better leave the slack-client unchanged, thus having the filtering logic in the slack-integration?

nliutyi-hs commented 2 years ago

Taking into account we anyway need to filter stuff from the cache, maybe it makes more sense.