search

HubSpot / vex

A modern dialog library which is highly configurable and easy to style. #hubspot-open-source
http://github.hubspot.com/vex/docs/welcome
MIT License
6.92k stars 494 forks source link

Still in production? #222

Closed RickKukiela closed 7 years ago

RickKukiela commented 7 years ago

Is this project still in production or has it been abandoned? There are bugs with fixes in PR's that that are two years old that have have not been integrated. I see tons of issues with no response going back over a year...

This is a great project, if the original developer is done with it we should consider forking it...

TrevorBurnham commented 7 years ago

HubSpot has switched to using React internally, so development has pretty much stopped on our jQuery-based projects. We've added one external contributor to this project, @bbatliner. If another team expressed serious interest in taking Vex off our hands, we'd be open to a transfer of ownership.

bbatliner commented 7 years ago

Hi SublymeRick, thanks for your concern. Vex underwent a major rewrite last summer to remove the jQuery dependency. A lot of the old pull requests are incompatible with the new code, but are left open in case contributors wished to adapt for the new version.

Unfortunately with work and school, Vex doesn't get a lot of my attention. I'm sorry we haven't kept up.

If you (and/or a team) is interested in forking or taking ownership, let's talk!

On Jun 27, 2017 10:24 AM, "SublymeRick" notifications@github.com wrote:

Is this project still in production or has it been abandoned? There are bugs with fixes in PR's that that are two years old that have have not been integrated. I see tons of issues with no response going back over a year...

This is a great project, if the original developer is done with it we should consider forking it...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/HubSpot/vex/issues/222, or mute the thread https://github.com/notifications/unsubscribe-auth/AFn50haE4CCxfwC3WH3AZF6R01VM_pKNks5sIR67gaJpZM4OGy1h .

RickKukiela commented 7 years ago

@bbatliner not sure I have the time for it right now either, but I would definitely be interested... Thing is my native js skills are pretty lacking as I've been living in the jquery world for so long now. I did just submit a PR with a quick fix to the scrolling problem. Its pretty simple but effective and it works even with multiple stacked instances. I would appreciate it if you could merge that in if you find it acceptable.

I'll keep this in mind, but unfortunately I don't have a team, just designers, which would be pretty useless on something like this... lol