search

HubSpot / vex

A modern dialog library which is highly configurable and easy to style. #hubspot-open-source
http://github.hubspot.com/vex/docs/welcome
MIT License
6.92k stars 491 forks source link

Set animation-fill-mode to fix .vex-closing flashing in IE 11 #233

Closed PixievoltNo1 closed 7 years ago

PixievoltNo1 commented 7 years ago

IE 11 usually has a frame or two between the end of .vex-closing's animation and the removal of the vex from the DOM, which causes the user to see a flash of the vex in its fully-open state. This is fixed by setting the animation-fill-mode property to forwards, which this commit adds to the animation shorthand.

bbatliner commented 7 years ago

This doesn't have any effects in other browsers, does it? I read through the MDN documentation for that property and that seems the case but I'm not a CSS animation expert.

PR looks good, can you confirm for me that this doesn't cause changes in other browsers? I'll merge in after.

PixievoltNo1 commented 7 years ago

No change in other browsers. I'm already using this in my own CSS without issue.

PixievoltNo1 commented 7 years ago

Looks like someone's reported this as an issue before; you can close #216 after merging this.