search

HubSpot / vex

A modern dialog library which is highly configurable and easy to style. #hubspot-open-source
http://github.hubspot.com/vex/docs/welcome
MIT License
6.92k stars 493 forks source link

vex's HubSpot site isn't updating #234

Closed PixievoltNo1 closed 7 years ago

PixievoltNo1 commented 7 years ago

The official docs at http://github.hubspot.com/vex/ haven't updated since version 3.0.0. This is especially concerning now that version 4 has changed the DOM structure, but http://github.hubspot.com/vex/api/advanced/ is showing the old one.

bbatliner commented 7 years ago

@adamschwartz I may have permission to publish on npm, but I believe someone internal to HubSpot needs to rebuild the docs from this repo. Can we update those?

adamschwartz commented 7 years ago

I’d love to help! But unfortunately as I have not worked at HubSpot since 2014 I no longer have access to the HSDocs tool which builds the docs for this project. Someone here should be able to help: https://github.com/orgs/HubSpot/people

timmfin commented 7 years ago

I should be able to look into in this weekend. Sorry for the delay!

timmfin commented 7 years ago

I pushed out updated docs, but it doesn't look like there were any documentation changes made in the repo during/after the 4.0.0 release. Do any docs need to be changed?

I'm happy to push out a docs update again if/when anything is changed.

PixievoltNo1 commented 7 years ago

Dunno what you mean by "no documentation changes"; the new DOM structure was documented, and that's now reflected at http://github.hubspot.com/vex/api/advanced/ , so we're all good there.

However, the site's title/h1 elements now say "vex-os" instead of just "vex".

timmfin commented 7 years ago

Apologies. I only looked around the commits in the 4.0 PR and thought I didn't see any markdown changes (I'm out of touch with this repo and totally missed the two line doc change: https://github.com/HubSpot/vex/commit/104a60a9999f965f22ced3ab712f1ff109ef0924#diff-2d9cabdfa28d8138aed4d55c870d2339L9).

I'll fix the vex-os bit shortly. (Done)