HubSpot / vex

A modern dialog library which is highly configurable and easy to style. #hubspot-open-source
http://github.hubspot.com/vex/docs/welcome
MIT License
6.92k stars 493 forks source link

Use Autoprefixer instead of prefixing mixins #236

Closed PixievoltNo1 closed 6 years ago

PixievoltNo1 commented 7 years ago

Currently, when using CSS properties or at-rules that need vendor prefixes, this project uses Sass mixins that compile to all possible variants. This has drawbacks:

IMO, a much better approach is to use Autoprefixer, which analyzes the CSS after Sass has done its work and adds only the prefixes needed according to the specified browserslist. I'm willing to do the work to migrate this project to Autoprefixer and submit a PR; I'd just like some indication that the work will be welcome.

This would entail a few things:

bbatliner commented 7 years ago

I've used similar tools in other projects, big fan. When I rewrote vex last year I focused on the JS because that was my expertise. An upgrade of the CSS side would be greatly appreciated! Thanks so much pikadude. Let me know how I can help.

PixievoltNo1 commented 7 years ago

Thanks for the positive response; I'll gladly get that done!

I have a question I hope you can answer: Is pie-clearfix (defined in _mixins.sass and used in vex-theme-*.sass) still needed for IE 9+? If it turns out it isn't, we can drop the entire _mixins.sass file.