search

HubSpot / vex

A modern dialog library which is highly configurable and easy to style. #hubspot-open-source
http://github.hubspot.com/vex/docs/welcome
MIT License
6.92k stars 494 forks source link

Demo broken #237

Closed abulka closed 7 years ago

abulka commented 7 years ago

Tried the demo today in both Chrome and Safari and all I got was a black screen after I hit the "demo" button. http://github.hubspot.com/vex/docs/welcome/

bbatliner commented 7 years ago

Huh, me too. That's not good! Any ideas what's going wrong?

KennySmash commented 7 years ago

I would wager a guess that the overlay background is popping forward on the z-index too much and also its stacking cause of the multiple modal windows

COLABORATI commented 7 years ago

same here on chromium ubuntu16.04

phra commented 7 years ago

screenshot from 2017-09-07 11-07-47

bbatliner commented 7 years ago

I made a workaround in ff15cf5. Basically the overlay is now added directly under the body, so using a different appendLocation other than the body will cause the dialogs to appear behind the overlay, unless that appendLocation also has a z-index greater than the overlay.

@timmfin Not sure if you rebuilt the docs from #241 already, but since this changes the demo index.html we'll need to rebuild again, right?

digitaldesigndj commented 7 years ago

The issue is still present, so I think it needs to be rebuilt ASAP. Trying to recommend this library 😱!

timmfin commented 7 years ago

Yup. Docs have been rebuilt now and the demo is working for me in Chrome and Safari. Apologies for the delay!