Documentation improvements

HubSpot / vex

A modern dialog library which is highly configurable and easy to style. #hubspot-open-source

http://github.hubspot.com/vex/docs/welcome

MIT License

6.92k stars 491 forks source link

Closed PixievoltNo1 closed 7 years ago

PixievoltNo1 commented 7 years ago

With these edits to the doc pages:

vex.defaultOptions is introduced to developers who, for whatever reason, skipped the Basic page and went right to Advanced
The closeAllOnPopState option is clarified, including the formerly-unmentioned wrinkle that it works only as a default option
A duplicate word error on the Themes page is fixed

Someone at HubSpot, perhaps @timmfin, will need to update vex's HubSpot site after this PR goes through.

PixievoltNo1 commented 7 years ago

Anything I can do to help get this merged?

bbatliner commented 7 years ago

Thank you for the reminder. Looks good. Merging in. @timmfin can rebuild the docs and we don't even need an npm publish. Thanks so much Pikadude 👍

timmfin commented 7 years ago