search

HubTurbo / addressbook

A small app for training and experimentation
Other
1 stars 3 forks source link

Improvement and more gui test cases. #557

Closed yl-coder closed 8 years ago

yl-coder commented 8 years ago

As per title. Fixes #565 Fixes #562

damithc commented 8 years ago

Need to do more comprehensive verification. Any GUI change that is expected should be verified. Any GUI element that is related but not expected to change should be verified to remain same.

damithc commented 8 years ago

A few more comments added.

yl-coder commented 8 years ago

Abit of refactoring done. Instead of using edit accelerator, created a editPerson(person) method which does the low level testing inside, and hide the implementation details of opening an editDialog. Moved the testing of opening an editdialog using accelerator into keybindingguitest, as i think it is more appropriate there.

damithc commented 8 years ago

Added some more comments.

yl-coder commented 8 years ago

made changes based on the comments. I will still improve other areas of the code. But i guess i will do it on another PR. Since there is a bug fix that needs to be pushed in for other PR.

yl-coder commented 8 years ago

feel free to comment now, but it not perfect yet. Will look through it again.

yl-coder commented 8 years ago

Merging this one. Will continue in another PR.