search

HubTurbo / addressbook

A small app for training and experimentation
Other
1 stars 3 forks source link

Add full GUI testing for tagging #559 #564

Closed m133225 closed 8 years ago

m133225 commented 8 years ago

Fixes #559

damithc commented 8 years ago

Added a few comments in passing. No a full review. Try to reduce verbosity of code by chaining and defining convenience methods (in place of repeated code blocks) in PageObject or the Test class itself.

m133225 commented 8 years ago

Seems to pass locally consistently. Will wait until #557 to further debug.

Also, when selecting multiple persons, each card handle tries to focus itself (multiple times?), causing large amounts of processing.

damithc commented 8 years ago

I think there is an undocumented keyboard shortcut in the edit dialog (Ctrl+O) that is not tested anywhere. Perhaps it's best to remove it? If not, we need to document it, test it, and also figure out how it should fit in with our keybinding component, which is supposed to capture all key bindings.

m133225 commented 8 years ago

It is in some of the tests already. However, I think it is better we remove it for now. Maybe we can introduce it back in future versions so as to implement bindings in dialogs (instead of just the main window), which could be useful for HT.

m133225 commented 8 years ago

Tests for tagging multiple persons seem to fail at verifying (on Travis) before grace period ends. Will look into it.

yl-coder commented 8 years ago

There is a typo in travis yml which causes screenshots not being able to upload. rebase to latest master to see screenshots

m133225 commented 8 years ago

Selecting multiple persons seem to not be working in headless mode, not just on Travis. Will attempt to run them in headful mode instead.