PersonCardHandle::isShowingGracePeriod fails sometimes

HubTurbo / addressbook

A small app for training and experimentation

Other

1 stars 3 forks source link

PersonCardHandle::isShowingGracePeriod fails sometimes #565

Closed m133225 closed 8 years ago

m133225 commented 8 years ago

Seems to fail when performing edits on a person other than alice.

isPendingStateRootVisible() returns false instead of the required true

damithc commented 8 years ago

We are taking screenshots right? What does the screenshot show? May be the grace period is too short?

m133225 commented 8 years ago

The pending label is there, similar to when the edit is made on alice but the method incorrectly returns a false if the edits are made on a different person. (tried on both benson and charlie)

yl-coder commented 8 years ago

I know what's wrong. Fixed it in my latest PR