search

Hubs-Foundation / dialog

Mediasoup based WebRTC SFU
Mozilla Public License 2.0
71 stars 84 forks source link

Avoid installing newer versions of mediasoup #30

Closed brianpeiris closed 2 years ago

brianpeiris commented 2 years ago

Not sure why we ever had this line in here. It seems wrong that we would want to install the latest version of mediasoup during the habitat build. It also resulted in the build failing due to other dependency mismatches. We should be relying on the version specified in package.json and package-lock.json instead, which is handled by npm ci.

netpro2k commented 2 years ago

Wow yeah that's pretty odd. I bet this means we have been running a different version of mediasoup than we expected.. It might be worth figuring out which version was actually in the last habitat build and updating to that, since that is what has been live on HMC for months.

brianpeiris commented 2 years ago

I've confirmed that HMC is running a slightly newer version of mediasoup compared to HC, because of this errant npm install line. Luckily, it seems harmless, since the differences are minor. Here is the diff: https://github.com/versatica/mediasoup/compare/3.6.37...3.7.0

Merging this will cause us to downgrade mediasoup the next time we deploy to HMC, but again that seems harmless.

brianpeiris commented 2 years ago

I'm going to merge this for now so that it doesn't bite us if we need to push a new dialog package to HC.