Hubs-Foundation / hubs-blender-exporter

The Hubs Blender Add-on enables artists to export their creations to the immersive web with Hubs
Mozilla Public License 2.0
165 stars 50 forks source link

Particle-updates #196

Closed keianhzo closed 1 year ago

keianhzo commented 1 year ago

This PR fixes the particle-emitter defaults so they are aligned with the client ones and adds a gizmo.

keianhzo commented 1 year ago

I'll need to fix the tests, is good to see that they are useful though :)

Exairnous commented 1 year ago

Nice! I really like the gizmo model and I think making it more consistent with Spoke is great. I have a couple notes/ideas though.

keianhzo commented 1 year ago

The velocity properties aren't getting Y and Z swapped on export.

I'm surprised that nobody has reported this in 6 moths. Maybe they are too annoying to use in Blender and nobody really does or maybe people just get used to swapping axis.

Exairnous commented 1 year ago

I'd guess it's probably a bit of both, plus I'm not sure particle emitters are as regularly used as other components.

Now that the axes are getting properly switched, I think there should be a version bump/migration for the component, the same as we did for media frames. And we may also want to switch the 0.5 velocities to the Y axis so that the end result matches the behavior in Spoke.

Also, it looks from my testing that the 2x2m plane you added to the gizmo should be rotated 90 degrees on the X axis. But I'm not sure what to do about the particle spray though, since the particle direction is determined by a combination of the object rotation plus the velocity values, it should theoretically be rotated separately from the plane, but I don't think that's really an option right now; so maybe for the time being it should keep its upwards orientation, but move it down and center it in the plane so it forms a kind of emblem?

keianhzo commented 1 year ago

I agree that showing the velocity on the gizmo should be very neat but I'm going to keep it simple for now and just add this improvements. We can do a pass sometime on making the gizmos a bit more fancy.