Hubs-Foundation / hubs-cloud

Resources for self hosted Hubs Cloud instances
Mozilla Public License 2.0
149 stars 88 forks source link

hcce codes and dockerfiles #340

Closed tanfarming closed 1 month ago

tanfarming commented 1 month ago
mikemorran commented 1 month ago

@tanfarming just finished testing out and I have a couple of other notes....

A. I got this error with line 19 of dockerbuildall.sh: "dockerbuildall.sh: line 19: ${dir,,}: bad substitution" B. Hubs' npm ci fails with a known error with PhantomJS (see this thread: https://discord.com/channels/498741086295031808/1182025615201804338/1196738177357066240). It can be fixed by specifying --platform=linux/amd64 but I wanted to ask your official take on the best way to fix it.

tanfarming commented 1 month ago

A. I got this error with line 19 of dockerbuildall.sh: "dockerbuildall.sh: line 19: ${dir,,}: bad substitution"

yeah i tested it on bash4, i guess you are running bash3? try to replace it with tag_name="${tagPrefix}$(echo "$dir" | tr '[:upper:]' '[:lower:]')" or tag_name="${tagPrefix}$(echo "$dir" | awk '{print tolower($0)}')" (cred. chatgpt lol)

B. Hubs' npm ci fails with a known error with PhantomJS (see this thread: https://discord.com/channels/498741086295031808/1182025615201804338/1196738177357066240). It can be fixed by specifying --platform=linux/amd64 but I wanted to ask your official take on the best way to fix it.

yep HrithikWins' answer there is perfect, tldr -- add --platform=linux/amd64 for none amd64 envs

mikemorran commented 1 month ago

Cool! I may just add a mention for it in the readme before deploying!