search

Hubs-Foundation / hubs-compose

Local development setup for Hubs
Mozilla Public License 2.0
41 stars 32 forks source link

init script ignores package-lock.json #34

Closed johnshaughnessy closed 1 year ago

johnshaughnessy commented 1 year ago

In https://github.com/mozilla/hubs-compose/pull/30 , npm ci was replaced with npm install --no-save in bin/init. This seems to cause the docker container to install incorrect package versions. Later, npm run local fails.

bryanenders commented 1 year ago

Thanks for calling this out. I overestimated the power of --no-save. This should be resolved by https://github.com/mozilla/hubs-compose/pull/35.