Make dependency installation more deterministic

Hubs-Foundation / hubs-compose

Local development setup for Hubs

Mozilla Public License 2.0

45 stars 38 forks source link

Make dependency installation more deterministic #35

Closed bryanenders closed 1 year ago

bryanenders commented 1 year ago

Fixes https://github.com/mozilla/hubs-compose/issues/34

Why

Although npm install --no-save doesn’t alter package-lock.json, it doesn’t honor package-lock.json any more than npm install. The clean install npm ci is time-consuming and should only be run if package-lock.json has changed.

How

Create conditional-npm-ci
Use conditional-npm-ci for Dialog, Hubs Admin, and Hubs Client

bryanenders commented 1 year ago

@johnshaughnessy You may want to run bin/init when you change service dependencies. I often run $ bin/services-update && bin/init.

johnshaughnessy commented 1 year ago

Oh, I see. That makes sense. Thanks!

bryanenders commented 1 year ago

Thanks for asking! I added a line to the README.