search

Hubs-Foundation / hubs-discord-bot

A Discord bot that helps you use Hubs together with people in Discord.
Mozilla Public License 2.0
49 stars 31 forks source link

Suggestion: Display name changes should be a new message #18

Closed misslivirose closed 5 years ago

misslivirose commented 5 years ago

Currently, if you are in a linked room and change your display name, instead of it showing up as: ' is now known as ', the bot edits the original message when you joined to reflect your new display name. This could make it harder to track down who is in the room. If the users can change their display names (even with the authentication to their Discord identity) then I think it makes more sense to have it as a message that mirrors what is said in the room chat.

mqp commented 5 years ago

The biggest reason I did it this way (editing the existing message) is because the first time you join the lobby, you get an autogenerated display name that you didn't choose or endorse, and it feels a little ridiculous to have the log full of "Whistler-Cake-14849 joined. Whistler-Cake-14849 is now known as Alice." But I agree that mirroring the room chat is a good property, and full traceability of what's going on is also good, so if you feel strongly then I will change it.

mqp commented 5 years ago

(By the way, I don't know if you noticed this, but it only edits the original message if you do it right after you join. If you change your display name later, it adds a new message.)

misslivirose commented 5 years ago

That makes sense - I changed it within a minute or two of joining, so I can imagine that I did that quickly enough to have it change the original message. That said, I think it could be confusing to still see someone join and not have a record of them later, but maybe just shortening the time frame between editing and making a new message would suffice. I'm seeing it still updating the original message 10+ minutes after joining, I would expect it to have a significantly shorter time frame for editing (Maybe around 5 minutes, tops)

mqp commented 5 years ago

Ah, it's my mistake -- it doesn't have a time window as long as the last arrival was of the same person. Reference: https://github.com/MozillaReality/hubs-discord-bot/blob/4ee8865c95de609c11068f16fd3c233fbcf72ce8/src/presence-rollups.js#L72-L81

I think I will add a short time window. Actually, I would shoot for even shorter than 5 minutes -- more like 1 minute, since I'm really only trying to deal with the "joined the lobby, instantly changed name before joining room" case. If you still see instances where this behavior seemed confusing or concerning let me know.

misslivirose commented 5 years ago

That sounds great 👍