Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.41k forks source link

"Take photo from all cameras" button takes multiple photos from the same camera. #2142

Open johnshaughnessy opened 4 years ago

johnshaughnessy commented 4 years ago

Description Pressing "x" to take a photo from all the cameras in the room instead takes multiple photos from a single camera.

To Reproduce Spawn two cameras in the room. (This requires two clients.) Press x. Two photos should appear, both from the same camera.

Expected behavior The button should take one photo from each camera in the room.

┆Issue is synchronized with this Jira Task

gfodor commented 4 years ago

When I wrote this feature originally, it was meant to make it so you could take a picture easily from your camera. Not sure if the "take picture from all cameras" is what we want, I hadn't considered it.

johnshaughnessy commented 4 years ago

Oh I see -- the bug may just be that it is not prioritizing the camera that you are holding when there are multiple in the room.

misslivirose commented 4 years ago

Yeah, taking pictures from all cameras in the room seems like a bit of an odd feature that is prone to possible griefing actions, I might recommend that the fix includes that element.

joshmarinacci commented 4 years ago

Has this been fixed?

misslivirose commented 4 years ago

No