Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.42k forks source link

Firefox Screen Sharing hurts performance even after turning screen sharing off #2246

Open kjjohnsen opened 4 years ago

kjjohnsen commented 4 years ago

Description If I screen share on firefox, the performance drops dramatically, and even when I remove it, the performance does not come back.

To Reproduce Steps to reproduce the behavior: Screen share Stop screen share

Expected behavior A clear and concise description of what you expected to happen. I somewhat expect the performance not to drop when I share, but I expect the performance to return when I stop sharing.

Hardware

Additional context Using hubs.ieeevr.online

┆Issue is synchronized with this Jira Task

arpu commented 4 years ago

what i see is if i stop screensharing the permission alert does not get removed it needs a track.stop()? in https://github.com/mozilla/hubs/blob/master/src/scene-entry-manager.js#L469

brianpeiris commented 4 years ago

Can confirm this. It's most noticeable if you share your entire screen.

keianhzo commented 3 years ago

@arpu Can you still reproduce this? We are already stopping the video track after the sharing ends: https://github.com/mozilla/hubs/blob/57f720bb372decb47980d118434d501bc2d31600/src/scene-entry-manager.js#L498