search

Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.41k forks source link

Object menu and emoji picker share keyboard shortcut? #2507

Open luser opened 4 years ago

luser commented 4 years ago

Description When pressing space bar to bring up the object menu for an object, the emoji picker also shows up. The emoji picker can get in the way of the object menu, which is frustrating.

To Reproduce Steps to reproduce the behavior:

  1. Point your cursor at an object.
  2. Press space to bring up the object menu.
  3. Note that the emoji picker also shows up.

Expected behavior These two functions should either have separate keyboard shortcuts, or the emoji picker should at least not be displayed when an object is highlighted.

Screenshots Screen Shot 2020-05-15 at 11 46 06 AM

Hardware

lordbron commented 4 years ago

I can understand the frustration here. While testing my fix for #1205, I experienced this a lot. (In fact, I think it's even visible in the bug and fix videos I made.)

However, what's the desired fix from the team and the submitter: Different shortcut keys or don't show emoji bar when selection is present?

I think I can probably do the latter, but haven't looked at any keyboard code yet for the former. If we could get consensus on the latter, I can give it a shot.

luser commented 4 years ago

However, what's the desired fix from the team and the submitter: Different shortcut keys or don't show emoji bar when selection is present?

Choosing a different shortcut key for the emoji picker might be a better overall solution since that'd make it less likely for users to accidentally bring it up if they are trying to select an object but miss it. I'd be happy if you fixed things to not bring up the emoji picker while an object is selected, though, since it's such a bad experience that it feels like a broken UI.

misslivirose commented 4 years ago

We've got a new design for this that moves some of the existing UI around into the settings menu and will separate the emoji shortcut from the object menu. It's going to be reviewed on Monday, and after that, we'll share the design here!