search

Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.41k forks source link

Make 'link' / 'url' an optional property for objects #2933

Open misslivirose opened 4 years ago

misslivirose commented 4 years ago

Is your feature request related to a problem? Please describe. Somewhat similar to https://github.com/mozilla/hubs/issues/2358, but a slightly more general-purpose feature. It would be cool if non-'link' objects in Hubs/Spoke could be used as links - for example, a 3D model of a shirt could link to the online store where you could purchase the shirt in a new tab.

This isn't as involved as having portals that act when you move between them, as described in #2358, but similar requests have come up that could be solved by allowing objects to have a URL property (e.g. #2502, #2100) and act as 'links'.

If the object had a link, hovering over it would show the button the way it currently does for images. One area of consideration is the placement of the button on 3D objects, but we could test out placing the button using the same logic that we do for the pause menu.

When in pause mode, the object menu would appear.

misslivirose commented 3 years ago

Another example of needing this surfaced today - a user wants to link a WebGL site in their room, but since our screenshot service doesn't support WebGL, we fail to render a useful preview of the scene.

Charlesc22 commented 3 years ago

Would love to see this feature. 3D models you could click on opens up all sorts of possibilities

Thanks Liv

cvanmeurs commented 3 years ago

Something to possibly consider is that if we allow objects to be links then we will probably need a way to know that on the back end when we are reviewing scenes, as it would be nearly impossible to go through a scene and try to click on every object to see if it is a link or not. So having some sort of "contains links" alert in the admin panel would possibly be a necessity if we are going to be certain that a scene does not contain a link to something harmful before we approve it.

matthewbcool commented 2 years ago

We may want to close this one since we can now achieve this functionally with the link component via the Blender exporter. It's not the perfect solution because you need to use a transparent preview (better maybe if we had the option to not render a preview?). unknown.