The "Share" button state is wrongly changed if the "Preference" page is open while sharing a screen - Githubissues

Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.

https://hubsfoundation.org

Mozilla Public License 2.0

2.13k stars 1.42k forks source link

The "Share" button state is wrongly changed if the "Preference" page is open while sharing a screen #4083

Open Softvision-RemusDranca opened 3 years ago

Softvision-RemusDranca commented 3 years ago

[Affected Versions]:

Safari 14
Firefox Release 87.0
Chrome 89

[Affected Platforms]:

MacOS 10.15.7
Windows 10x64
Iphone SE

[Prerequisites]:

Have a room opened on "https://hubs.mozilla.com/" website.

[Steps to reproduce]:

Click the "Share" button from the menu bar.
Select one of the options(Camera or Screen).
Open the Preference page from the More menu.
Close the Preference page.
Click the Share button and observe the behavior.

[Expected results]:

The shared option is closed.

[Actual results]:

The Share menu is displayed and the Camera or Screen are actionable.

[Notes]:

It can be observed that the Share button state is changed also by observing that the red dot is no longer displayed above the button after closing the Preference page.
If the Camera or Screen buttons are clicked after reproducing the issue the first spawned option freezes and the second remains in a loading state.
Attached is a screen recording of the issue:

┆Issue is synchronized with this Jira Task

dezigns333 commented 3 years ago

Interesting side note. I noticed that a microphone has to be present to properly share a screen that has audio coming from it (ie. youtube). I didn't know if this was on purpose but it felt limiting.