matthewbcool
commented
2 years ago Able to reproduce when pdf is pinned.
Open stylianosm2 opened 2 years ago
matthewbcool
commented
2 years ago Able to reproduce when pdf is pinned.
keianhzo
commented
2 years ago This is related to this commend from @netpro2k https://github.com/mozilla/hubs/pull/4642#issuecomment-919479006 We pin the document to sync it's state. I'm not sure what's the expected behavior there: if we want the object state to be synced across sessions we shouldn't allow non authenticated users to pin but at the same time it's pretty annoying that you can't read the pdf if you are not signed-in...
stylianosm2
commented
2 years ago Hello @keianhzo , there are two distinct conditions and actions: a) browsing/interacting with pinned objects and b) pinning new objects. This reported issue is about the first case, (a). In my view, the desired behavior is the following: If a pdf is pinned, non authenticated users should be able to reproduce it and change pages. In this case, these guests do not attempt to pin or un-pin an object, they simply interact with it. For instance interaction controls in pinned external videos work fine and this pop-up does not appear. This should be achieved also with pdf files. I hope this is clear.
Softvision-RemusDranca
commented
2 years ago Not sure what's the expected behaviour on this, but it seems that the page is changed even if the Sign in to pin objects prompt is displayed.
aziliak
commented
2 years ago This issue still persists.
I want to be able to pin a PDF to a point but still allow the user to scroll through the PDF. Currently this doesn't seem possible. I'm ok if this this doesn't get resolve through this feature, but we should be able to upload a PDF through Spoke and have the PDF work in this manner where the PDF stays in place and anyone can scroll through the PDF.
keianhzo
commented
2 years ago Related: https://github.com/mozilla/hubs/issues/5063 Related: https://github.com/mozilla/hubs/issues/5081
I agree that pinning is currently quite confusing because it bundles two different functionalities in one: Locking the position and persisting the object in the room. The scope of this issue is much broader than just allowing paging while unpinned so I'm going to defer this to the product team to evaluate what the best path to follow and what should be the right design for this feature. There are already some well-formed community proposals like this one from @Exarnious. If anyone has other ideas I recommend to discuss them in that proposal thread.
One issue that I've seen while testing this is that before an object is pinned for the first time any logged or not logged user can interact with the controls but if a logged user pins/unpins it, non-logged users can't interact with it anymore without seeing the sign-in modal. I think that a current bug and we should fix it for consistency.
brianpeiris
commented
2 years ago A workaround to this issue is to use Spoke's "Image" element to add PDFs to a scene. Users will be able to change PDFs' pages without signing in, since the PDFs will be part of the scene, instead of being pinned objects in the room.
aziliak
commented
2 years ago @brianpeiris I tried that but I wasn't able to upload a PDF. I'll have to try that again.
naoki1219aic
commented
1 year ago @brianpeiris hi. how to uproad pdf to spoke.I don't think spoke can upload pdfs, how do you do it?
Description I have created a virtual exhibition. Visitors should be able to view multimedia (images/videos) and mainly pdf files. Whenever visitors/guests try to browse a pdf containing multiple pages, a pop-up screen appears prompting them to sign-up so as to pin objects. Is there a way to get rid of this message? I have activated all options in room's options.
To Reproduce Steps to reproduce the behavior:
Expected behavior Guests should be able to see and browse pdf files without a pop-up message.
Screenshots I attach a screenshot.
Hardware
Additional context Any help is highly appreciated, thanks in advance!
┆Issue is synchronized with this Jira Task